Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

use muon.file.writeImportant to write ledger files #8602

Closed
mrose17 opened this issue May 1, 2017 · 0 comments
Closed

use muon.file.writeImportant to write ledger files #8602

mrose17 opened this issue May 1, 2017 · 0 comments

Comments

@mrose17
Copy link
Member

mrose17 commented May 1, 2017

Test plan

#8605 (comment)


  • Did you search for similar issues before submitting this one? yes

  • Describe the issue you encountered: replace atomicWriter in ledger.js with muon.file.writeImportant

  • Platform (Win7, 8, 10? macOS? Linux distro?): all

  • Brave Version (revision SHA): all

  • Steps to reproduce:

    1. start browser
    2. visit enough sites for enough time to cause ledger-synopsis.json to be written
  • Actual result: files are written without corruption

  • Expected result: same

  • Will the steps above reproduce in a fresh profile? no. If not what other info can be added? visit some sites to ledger-synopsis.json gets written

  • Is this an issue in the currently released version? yes

  • Can this issue be consistently reproduced? yes

  • Extra QA steps: none

  • Screenshot if needed: none

  • Any related issues: based on use write.writeImportant for session store #8593

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.