Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension: MetaMask #8671

Closed
13 tasks done
jonathansampson opened this issue May 4, 2017 · 7 comments
Closed
13 tasks done

Extension: MetaMask #8671

jonathansampson opened this issue May 4, 2017 · 7 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented May 4, 2017

QA steps here!!!

#11534


Extension: MetaMask

image

For development purposes, the background page for this extension can be accessed by navigating to the following URL: chrome-extension://dkjoiblfkdpnahoolgkbmgihdfkflnkm/_generated_background_page.html

Needed APIs:

chrome.browserAction

chrome.extension

chrome.runtime

chrome.tabs

chrome.windows

@kevinlawler
Copy link
Contributor

kevinlawler commented Jun 20, 2017

@snapshot of working/non-working functionality as of this morning:

Window loads when fox icon clicked: Yes
Accepting Terms works:              Yes
Saving secret words works:          Yes
Main account page displayed:        Yes
Switching networks:                 Yes
Switch accounts page displays:      Yes
Hamburger menu displays:            Yes
Create additional account:          Yes
Etherscan Link:                     Yes
Buy from Coinbase, full flow        Yes
Close window button after CB buy    No
"Continue to Coinbase"              Yes, No if switched back from Shapeshift (bug?)
Buy:                                Yes (checked w/ Coinbase)
Send:                               Yes (checked w/ Coinbase)
Coinbase confirmed:                 Yes
Badge:                              Yes, seemed to work for me
Website integration:                Yes* (*no window appears, must click)
Web window appears automatically:   No
Website integration, full flow:     Yes (for both successes and failures)

kevinlawler added a commit to brave/vault-updater that referenced this issue Jun 20, 2017
kevinlawler added a commit that referenced this issue Jun 21, 2017
#8671

already added to vault manifest & live on server
brave/vault-updater#43

Auditors:
@bridriver @bsclifton @jonathansampson
@bsclifton bsclifton modified the milestone: 0.18.x (Developer Channel) Jun 27, 2017
bbondy pushed a commit that referenced this issue Jul 4, 2017
#8671

already added to vault manifest & live on server
brave/vault-updater#43

Auditors:
@bridriver @bsclifton @jonathansampson
@bbondy bbondy added this to the 0.18.x (Beta Channel) milestone Jul 4, 2017
@bsclifton
Copy link
Member

@kevinlawler we merged your changes with #9647; is there anything needed before we close this issue? It looks like some of the items above are still marked as open... but they may be optional or just referenced this issue. I am thinking this can be closed?

@kevinlawler
Copy link
Contributor

@bsclifton leave this issue open. we use these to track the remaining incompatibilities

@bsclifton
Copy link
Member

@kevinlawler OK sounds great! I'll remove milestone

@bsclifton bsclifton removed this from the 0.18.x (Beta Channel) milestone Jul 11, 2017
@ghost ghost added the Epic label Aug 31, 2017
@jonathansampson jonathansampson added this to the 0.20.x (Developer Channel) milestone Sep 21, 2017
@ghost ghost added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@bneiluj
Copy link

bneiluj commented Oct 8, 2017

Any news on Metamask extension ?

kjozwiak pushed a commit that referenced this issue Oct 14, 2017
#8671

already added to vault manifest & live on server
brave/vault-updater#43

Auditors:
@bridriver @bsclifton @jonathansampson
kjozwiak pushed a commit that referenced this issue Oct 14, 2017
#8671

already added to vault manifest & live on server
brave/vault-updater#43

Auditors:
@bridriver @bsclifton @jonathansampson
@darkdh
Copy link
Member

darkdh commented Oct 15, 2017

nothing blocks Metamask now 😉

@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 1 (Release channel) Oct 16, 2017
@bbondy
Copy link
Member

bbondy commented Oct 16, 2017

Closing since this is included.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants