Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import passwords from Firefox #9292

Closed
darkdh opened this issue Jun 6, 2017 · 3 comments · Fixed by #9433
Closed

Import passwords from Firefox #9292

darkdh opened this issue Jun 6, 2017 · 3 comments · Fixed by #9433

Comments

@darkdh
Copy link
Member

darkdh commented Jun 6, 2017

including passwords list and never saved list

@darkdh darkdh added this to the 0.18.x milestone Jun 6, 2017
@darkdh darkdh self-assigned this Jun 6, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
@darkdh darkdh changed the title Import passwords Import passwords from Firefox Jun 13, 2017
@darkdh darkdh removed their assignment Jun 13, 2017
@darkdh darkdh self-assigned this Jun 14, 2017
evq added a commit to evq/browser-laptop that referenced this issue Jun 14, 2017
evq added a commit to evq/browser-laptop that referenced this issue Jun 20, 2017
@darkdh darkdh added the hackday Legacy label for a one-day hack-session. label Jul 20, 2017
@kjozwiak
Copy link
Member

kjozwiak commented Sep 27, 2017

@darkdh, is the following test case sufficient enough to test this feature?

Test Case:

Under Firefox:

  • login into several different websites and save the passwords
  • login into several other websites and this time select "Never Save" under the permission dropdown menu
  • visit about:preferences#security
  • click on "Saved Logins..." and ensure that the saved passwords are being listed
  • click on "Exceptions" and ensure that the websites are being listed

Under Brave:

  • visit about:preferences
  • under "Import Browser Data", click on the "Import Now..." button
  • select firefox from the dropdown menu and ensure "Saved passwords" is selected
  • Click on "Import"
  • Once you've received the "Your data has been imported to Brave successfully.", click on the "Ok" button
  • visit about:passwords
  • ensure that the saved passwords are being listed under "Saved passwords:"
  • ensure that the websites that have been added into the exceptions list are being listed under "Never save passwords on these sites:"
  • load the website that have a saved password and ensure that they're correctly being filled into the appropriate fields
  • load the websites that are part of the exceptions list and ensure that you're not prompted to save the password once logged in

@darkdh
Copy link
Member Author

darkdh commented Sep 27, 2017

yes, but missing never saved list.
make sure you have this in Firefox
screen shot 2017-09-26 at 9 09 20 pm
and the site will be imported to our never saved list.
When you type username/passwords on the site, we will not prompt you to save password.

@kjozwiak
Copy link
Member

Thanks @darkdh, updated the above test case!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.