Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Rename Yes/No buttons to Allow/Deny for easier understanding #9750

Closed
srirambv opened this issue Jun 28, 2017 · 8 comments · Fixed by #10180 or #12387
Closed

Rename Yes/No buttons to Allow/Deny for easier understanding #9750

srirambv opened this issue Jun 28, 2017 · 8 comments · Fixed by #10180 or #12387

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 28, 2017

Test plan

#10180 (comment)


  • Did you search for similar issues before submitting this one
    Yes?

  • Describe the issue you encountered:

making the controls "Deny" and "Allow" (again, as for Flash) instead of "No" and "Yes" would be more clear to me. More than once, I've nearly clicked "Yes" with the feeling that I was confirming the "remember for this site" checkbox.

@bsclifton
Copy link
Member

This is a nice polishing step IMO

WDYT, @bradleyrichter @alexwykoff ?

@bradleyrichter
Copy link
Contributor

I agree. But I would like to see a table of all alert messages and refine them all in one go if possible.

@cezaraugusto @bsclifton Can we generate this table? Or is it a matter of cherry picking strings?

@cezaraugusto
Copy link
Contributor

only way is manually I think, I'll take care of that

@cndouglas
Copy link

+1 from me.

@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 3, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@srirambv
Copy link
Collaborator Author

Reopening issue based on #10180 (comment)

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 3, 2018

@cezaraugusto @bradleyrichter Should the order be Allow/Deny/Never remember or Deny/Allow/Never Remember to keep consitency
image

@cezaraugusto
Copy link
Contributor

deferring to @bradleyrichter

@bradleyrichter
Copy link
Contributor

"Would you like Brave to save this password" = No/Yes

"Allow Brave to save this password" = Deny/Allow

So I think our strings are currently phrased for No/Yes.

Also, we need to follow the style for "Continue-Yes on the Right side". This is the internet standard and only Windows still uses the inverse approach.

Our new approach should follow this mockup:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.