Improve install instructions for Linux Mint #11241
Conversation
The `lsb_release` method doesn't work for Mint since it's not explicitly supported. This adds instructions for using the upstream Ubuntu name instead. fix #6446
Looks good at first glance. Thanks for doing this BTW. I assume you only tested one version? It's an improvement either way |
Correct, I only tested for Sonya, but I can run through a couple others if you like. |
It's always good to know which ones work. I'm always surprised + I will give you a shoutout on the blog post I am releasing. |
I'll give a few a run through! I'm surely no stranger to surprises in the least expected places. Do you think one test per Ubuntu base should be enough? Say, Sonya, Rosa and Betsy? |
@Raindeer44 Because of my usual habits we get good coverage on 14,16 and 17. I also test and verify that I can build on Debian testing generally |
@posix4e I can do 16, 17 and LMDE for sure, but I don't have 14 available off-hand and I'd have to track down the ISO for a VM. Regular Debian should still work with the |
@Raindeer44 OOh I mean I test ubuntu 14 lts, 16 lts and whatever new 17 is |
@posix4e OHHH yeah, that makes a lot of sense. Mint is based on Ubuntu's LTS's so then testing Mint 17 and 18 (Ubuntu 14 and 16) should cover it, plus LMDE for good measure. |
Codecov Report
@@ Coverage Diff @@
## master #11241 +/- ##
==========================================
- Coverage 54.32% 51.47% -2.86%
==========================================
Files 255 263 +8
Lines 22070 25484 +3414
Branches 3446 4310 +864
==========================================
+ Hits 11990 13117 +1127
- Misses 10080 12367 +2287
|
To be clear (just in case), I did successfully test these changed instructions on Linux Mint 17, 18 and LMDE 2 👍 |
fix #6446
The
lsb_release
method doesn't work for Mint since it's notexplicitly supported. This adds instructions for using the upstream
Ubuntu name instead.
Also a couple of formatting changes (no content change), and the word Brave was capitalized.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Since this is a text documentation file only, I didn't run any tests. If there are some to run, please let me know, I'd be happy run them.
Reviewer Checklist:
Tests