Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Copy animation in backup wallet #13772

Conversation

arsalankhalid
Copy link
Contributor

@arsalankhalid arsalankhalid commented Apr 9, 2018

For issue #6459

  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request
    @NejcZdovc , @bsclifton

Cheers.

@arsalankhalid arsalankhalid force-pushed the 6459_CopyAnimationInBackupWallet branch from f174ee7 to ae1d0e5 Compare April 9, 2018 03:59
@codecov-io
Copy link

codecov-io commented Apr 9, 2018

Codecov Report

Merging #13772 into master will decrease coverage by 0.3%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master   #13772      +/-   ##
==========================================
- Coverage   56.77%   56.46%   -0.31%     
==========================================
  Files         285      283       -2     
  Lines       29042    29006      -36     
  Branches     4800     4813      +13     
==========================================
- Hits        16489    16379     -110     
- Misses      12553    12627      +74
Flag Coverage Δ
#unittest 56.46% <28.57%> (-0.31%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/common/clipboardButton.js 29.78% <18.18%> (-10.22%) ⬇️
...rer/components/preferences/payment/ledgerBackup.js 38.46% <66.66%> (+1.61%) ⬆️
...rer/components/preferences/payment/deletedSites.js 41.02% <0%> (-7.46%) ⬇️
app/renderer/components/common/sortableTable.js 55.61% <0%> (-6.5%) ⬇️
app/browser/reducers/windowsReducer.js 77.39% <0%> (-3.47%) ⬇️
app/renderer/components/preferences/paymentsTab.js 68.27% <0%> (-2.95%) ⬇️
app/sessionStore.js 85.71% <0%> (-2.7%) ⬇️
app/browser/reducers/tabsReducer.js 37.56% <0%> (-2.39%) ⬇️
...erer/components/preferences/payment/ledgerTable.js 84.25% <0%> (-1.87%) ⬇️
... and 37 more

@NejcZdovc
Copy link
Contributor

@arsalankhalid thank you for you PR. Can we please adjust this one and just add text bellow the button, when button is clicked. Text should fade out after 5s.

Something like this:
image

@arsalankhalid
Copy link
Contributor Author

Ah OK, keep the button and no img then. Sure will fade out the text

@arsalankhalid
Copy link
Contributor Author

Sorry team been a bit busy, will update and push today :)

@NejcZdovc
Copy link
Contributor

@arsalankhalid no worries, thank you

@arsalankhalid
Copy link
Contributor Author

Cleaning my branch ignore for now

@NejcZdovc
Copy link
Contributor

PR ignored 😃

@NejcZdovc
Copy link
Contributor

@arsalankhalid just checking how are things?

@NejcZdovc NejcZdovc removed their request for review May 3, 2018 17:53
@arsalankhalid
Copy link
Contributor Author

Hey @NejcZdovc sorry got pulled away and went on vacation, I'll hit this up and clear this out on the weekend. My fault, shouldn't have taken so long...

@NejcZdovc
Copy link
Contributor

@arsalankhalid no worries, hope that you enjoyed your vacation

@arsalankhalid
Copy link
Contributor Author

Sorry guys, i'll definitely push my update tomorrow, i've been a terrible loaft.

@bsclifton bsclifton added the stale label Sep 8, 2018
@bsclifton bsclifton closed this Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants