Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use v2 promotion endpoints #15003

Merged
merged 1 commit into from Aug 19, 2018
Merged

Use v2 promotion endpoints #15003

merged 1 commit into from Aug 19, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 13, 2018

Resolves #14980

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • run browser with the staging flag
  • enable payments
  • claim grant
  • make sure that color that is selected matches the options
  • dnd triangle to the wrong color and make sure that you get a new captcha
  • dnd triangle to the correct color and make sure that grant is claimed successfully

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Aug 13, 2018

blocked on brave-intl/bat-client#93

@evq evq changed the title Adds new captcha Use v2 promotion endpoints Aug 15, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@bsclifton bsclifton merged commit 972e9b4 into brave:master Aug 19, 2018
@evq evq mentioned this pull request Aug 19, 2018
bsclifton added a commit that referenced this pull request Aug 19, 2018
bsclifton added a commit that referenced this pull request Aug 19, 2018
@bsclifton
Copy link
Member

master 972e9b4
0.24.x 0a0ee2f
0.23.x b511d2e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants