This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bookmarks now show under Bookmarks menu #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to wait until #3022 is fixed as well. Could you do another commit for that in this same PR? |
|
Sure- I'll start looking at this tomorrow |
This was referenced Aug 11, 2016
- Small refactor in siteUtil.js; trying to make sure bookmark code is consistent, because bookmarks menu will use similar code to the bookmarks toolbar. - Subfolders now shown in menu - Folder menu items with 0 children no longer include empty submenu - Refactored code in menu.js; all submenus are defined above the template definition. - Bookmark menu selections now respect secondary keys - Fixes #1993 - Created siteUtilTest file, moved some existing tests over, and added more tests
…the unit tests. uitest will ONLY run the spectron tests. You can continue to use the grep syntax to run specific tests.
#3022 - The Bookmarks/History menus will now properly rebuild themselves when the appStore's sites list changes (site is bookmarked, new site added to history) - Fixed bug where initial browser's initial state thinks the first page loaded is NOT bookmarked, even when it is. Fixes #3098 - Updated siteUtil.getBookmarks to default to [] if no items found
…next step would be finding an efficient way to only modify the history and bookmarks menus.
|
@bbondy per your comment, I backed out the change that adds the dynamic parts of the bookmarks menu. It should be safe to merge this now as it won't rebuild the menu. I'm working on the history menu right now too (separate of this), so I'll be sure to dig in and properly handle dynamic menus 😄 |
|
great, thanks! Merging. This won't be in 0.11.5 btw which is good anyway because it'll give us time to find any issues with the menus. |
This was referenced Aug 21, 2016
|
For QA: To be clear, this is not inclusive of the hamburger menu. |
This was referenced Aug 23, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.