Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds about:history, sets back/forward nav limit, more efficient dynamic menus #3206

Merged
merged 6 commits into from
Aug 17, 2016
Merged

Adds about:history, sets back/forward nav limit, more efficient dynamic menus #3206

merged 6 commits into from
Aug 17, 2016

Commits on Aug 17, 2016

  1. - Brand new about:history page. It's very minimal but works (you can … 

    …double click entries to launch),

- History menu now has a "Show Full History" which pulls up about:history. Fixes #444
- History in back/forward nav buttons is limited to 10. Fixes #2889
- History menu shows recently closed frames (based on WindowState)
- Broke methods out from menu.js to a helper file (menuUtil.js)
- menuUtil tests now use mockery (and work properly), stubbing electron (we can also unit test other electron dependent code like this).
- history and bookmarks menus are now dynamic and uses clear/insert calls instead of rebuilding all menu items. Fixes #1993
- history menu now considers modifier keys (similar to bookmarks menu)
    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    2e238dc View commit details
    Browse the repository at this point in the history

  2. Remove console logs

    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    c56f3f6 View commit details
    Browse the repository at this point in the history

  3. Feedback part 1; note-worthy items: 

    - Renamed IPC message names to be more specific
- Only closedFrames is sent to menu update now (and it's immutable, matching the other param)
- Added .get('location') to the bookmarks/history items for a fallback title
- "Show History" is now always present on back/forward nav button long press menu (thanks for reviewing, @bradleyrichter)
- Fixed bug where only 9 items would show on back/forward nav button long press
- Noticed something I missed; when closedFrames changes, it needs to trigger a menu update. Put placeholder TODO.
    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    9774bfb View commit details
    Browse the repository at this point in the history

  4. Feedback part 2; note-worthy items: 

    - Menu now rebuilds on BrowserWindow focus
- Fixed bug where "Bookmark Page" menu item's check status could be out of sync (got updated via AppStore)
    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    36081c0 View commit details
    Browse the repository at this point in the history

  5. Feedback part 3; note-worthy items: 

    - Fixed issue where empty session would not initialize menu
- Closing frames will now fire Menu update (for the History > Recently Closed)
    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    cf083e7 View commit details
    Browse the repository at this point in the history

  6. Small fix- forgot to check if value is initialized before using

    @bsclifton
    bsclifton committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    8a044fc View commit details
    Browse the repository at this point in the history