This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
extension actions #3867
Merged
extension actions #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still has a few small open todos |
|
Great job with the tests on this one! This should make adding new extensions really easy 😄 |
bridiver
force-pushed
the
extension-actions
branch
from
762678e
to
aec37e9
Compare
|
requires brave/muon@8d8dc9d |
bridiver
force-pushed
the
extension-actions
branch
from
aec37e9
to
a98d9e5
Compare
bridiver
force-pushed
the
extension-actions
branch
from
a98d9e5
to
9e77381
Compare
| @@ -289,6 +289,8 @@ module.exports.cleanAppData = (data, isShutdown) => { | |||
| // if (data.tabs) { | |||
| // data.tabs = data.tabs.map((tab) => tabState.getPersistentTabState(tab).toJS()) | |||
| // } | |||
| // TODO(bridiver) - really just need to clear out tabId related stuff | |||
| delete data.extensions | |||
There was a problem hiding this comment.
I'll change this when I PR my stuff.
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan:
Select Dashlane as password manager
Dashlane icon should appear next to Brave shields icon
Clicking Dashlane icon should open the Dashlane popup
Same thing for Lastpass
Fix #2224