This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Favicon is now updated in session after visiting site #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to make sure we get the latest favicons for the new about:newtab page, our bookmarks toolbar, and also the about:bookmarks page. Before, the favicon was only being updated: - when site is bookmarked / rebookmarked - when site is pinned Auditors: @darkdh @cezaraugusto Fixes #4860 Test Plan: 1. Import bookmarks from Chrome or HTML... OR manually create a new bookmark (from about:bookmarks) 2. Show the bookmarks toolbar and notice the favicon is not loaded 3. Load/visit one of the bookmarks which does NOT have a favicon yet 4. After visiting the page, notice that the favicon is updated Fixes #2747 Test Plan: 1. Open a new tab 2. Per issue description, visit tokyo.cawaii.media/gisele/ 3. Go back to the empty tab by pressing the back button 4. Press and hold the forward button to display the pulldown
darkdh
reviewed
Oct 31, 2016
| @@ -770,6 +770,9 @@ const handleAppAction = (action) => { | |||
| case AppConstants.APP_DEFAULT_BROWSER_CHECK_COMPLETE: | |||
| appState = appState.set('defaultBrowserCheckComplete', {}) | |||
| break | |||
| case WindowConstants.WINDOW_SET_FAVICON: | |||
There was a problem hiding this comment.
Who dispatches WINDOW_SET_FAVICON? I didn't see it in this PR
There was a problem hiding this comment.
already existing windowAction.setFavicon
There was a problem hiding this comment.
yes- which is triggered in frame.js, from the page-favicon-updated handler 😄
|
++ |
This was referenced Nov 2, 2016
|
Note: #4860 will be fixed in 0.12.9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Required to make sure we get the latest favicons for the new about:newtab page,
our bookmarks toolbar, and also the about:bookmarks page. Before, the favicon
was only being updated:
Auditors: @darkdh @cezaraugusto
Fixes #4860
Test Plan:
Fixes #2747
Test Plan:
Fixes #5148
Test Plan: