Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds title attributes to extension buttons #8282

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

jonathansampson
Copy link
Collaborator

Test Plan:

With a screen reader enabled:

  1. Place focus on address bar
  2. Press tab until extension buttons are encountered
  3. Listen for extension name to be mentioned

PR Details:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8269

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Good catch- this is a nice touch 😄

(btw- I only tested using mouse hover, rather than with screen reader)

@bsclifton bsclifton merged commit 5a0e134 into master Apr 13, 2017
@bsclifton bsclifton deleted the a11y-read-extension-buttons branch April 13, 2017 17:38
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants