This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactors MenuBar and MenuBarItem into redux component #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
NejcZdovc
force-pushed
the
redux/menubar
branch
3 times, most recently
from
b8c397f
to
7dcb919
Compare
bsclifton
suggested changes
May 3, 2017
There was a problem hiding this comment.
Code changes look good- some notes as I'm testing on Windows:
- when "Hide the menu bar by default" is true, the menus will automatically open (without clicking), which is not correct. Before, it would require a click to open the menu
That seems to be the only thing I can find 👍
|
@bsclifton fix added. Can you please retest it? |
Resolves brave#8652 Auditors: @bsclifton @bridiver Test Plan: - open menu on windows - try clicking around - everything should behave as did before
bsclifton
approved these changes
May 4, 2017
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Description
git rebase -ito squash commits (if needed).Resolves #8652
Auditors: @bsclifton @bridiver