This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
the-atlantic-allow-1p-ab-checks #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for 1p checks for theatlantic.com - Will allow for additional filters to be applied in `brave/adblock-lists` to prevent content blocking. - WIll provide flexibility for additional filters, should the URL change to another 1p URL.
jonathansampson
approved these changes
May 7, 2017
|
Thanks @jonathansampson! @bsclifton too! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for 1p checks for theatlantic.com. Fixes #6291
Will allow for additional filters to be applied in
brave/adblock-liststo prevent content blocking.WIll provide flexibility for additional filters, should the URL change to another 1p URL.
Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran
git rebase -ito squash commits (if needed).Test Plan:
about:adblockabout:adblockpageOnce the PR has been confirmed, I will update adblock-lists with the custom filters from above, and have dat files pushed. Custom filters will serve the same purpose for testing, and limit potential risk.
The
please-support-usurl redirects the user to the blocker page.The blueconic.com URL is used to track users.