Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix ledger balance check enable/disable #9318

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 7, 2017

Test plan

See #9317

Description

fix #9317

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added this to the 0.18.x milestone Jun 7, 2017
@bridiver bridiver self-assigned this Jun 7, 2017
@bridiver
Copy link
Collaborator Author

bridiver commented Jun 7, 2017

mentioned on the ticket, but this change was made for two reasons:

  1. tabs doesn't exist in windowState anymore so the current check won't work
  2. iterating through all the tabs is very slow when you have a lot of tabs

@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Frozen, only critical adds from here), 0.18.x Jun 7, 2017
@NejcZdovc
Copy link
Contributor

We need to put this into 0.17, because in 0.17 we removed tabs from windowState

@alexwykoff alexwykoff modified the milestones: 0.18.x (Frozen, only critical adds from here), 0.17.x (Frozen, only critical adds from here), 0.19.x Jun 12, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Beta Channel), 0.19.x (Nightly Channel) Jun 13, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in some logging, manually tested each scenario-
works great 😄

I'll document the steps I tried in the issue for the test plan

@bsclifton bsclifton merged commit 915e13e into master Jun 14, 2017
@bsclifton bsclifton deleted the ledger-balance-update branch June 14, 2017 06:32
bsclifton added a commit that referenced this pull request Jun 14, 2017
fix ledger balance check enable/disable
bsclifton added a commit that referenced this pull request Jun 14, 2017
fix ledger balance check enable/disable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ledger balance updater doesn't turn on/off when payments tab is activated
4 participants