This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Converts ImportBrowserDataPanel into redux component #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
redux/importBrowserDataPanel
branch
7 times, most recently
from
7a4ed0e
to
fe19bdb
Compare
51 tasks
darkdh
suggested changes
Jun 15, 2017
|
Let me try it again, it was working correctly for me when I was testing it |
|
@darkdh can you please try again |
NejcZdovc
force-pushed
the
redux/importBrowserDataPanel
branch
from
fe19bdb
to
2243e9b
Compare
darkdh
reviewed
Jun 16, 2017
| props.browserNames = importBrowserDataDetail.map((browser) => browser.get('name')) | ||
| props.browserIndexes = importBrowserDataDetail.map((browser) => browser.get('index')) | ||
| props.isSupportingHistory = currentBrowser.get('history', false) | ||
| props.isSupportingFavourites = currentBrowser.get('favorites', false) |
| const importBrowserDataSelected = currentWindow.get('importBrowserDataSelected', Immutable.Map()) | ||
| const importBrowserDataDetail = currentWindow.get('importBrowserDataDetail', Immutable.Map()) | ||
| const index = importBrowserDataSelected.get('index', '0') | ||
| const currentBrowser = importBrowserDataDetail.get(index, Immutable.Map()) |
There was a problem hiding this comment.
currentSelectedBrowser would be better
| data.favorites = this.props.favorites | ||
| data.history = this.props.history | ||
|
|
||
| if (this.props.type != null) { |
There was a problem hiding this comment.
we can remove this check. type will always has value which comes from muon.
|
|
||
| componentWillMount () { | ||
| if (this.props.selectedIndex == null) { | ||
| windowActions.setImportBrowserDataSelected(0) |
| } | ||
|
|
||
| componentWillMount () { | ||
| if (this.props.selectedIndex == null) { |
There was a problem hiding this comment.
I think this check can be removed. Is there any case it will have value when componentWillMount being called?
Resolves brave#9442 Auditors: @bsclifton @bridiver Test Plan:
NejcZdovc
force-pushed
the
redux/importBrowserDataPanel
branch
from
2243e9b
to
701c9b4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9442
Auditors: @bsclifton @bridiver
Test Plan:
Reviewer Checklist:
Tests