Set TTL attribute when soft-delete a sync item #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
husobee
approved these changes
Jun 9, 2020
| // items automatically by dynamoDB. | ||
| if *entity.Deleted { | ||
| update = update.Set(expression.Name(ttlAttrName), expression.Value(time.Now().Add(ttl).Unix())) | ||
| } |
There was a problem hiding this comment.
This means we will delete this forever, and will not be recoverable. I would suggest we create a cold storage s3 bucket where these soft deleted expired items exist. Or we need clear expectations to the users that soft delete means it will be deleted forever after 90 days.
There was a problem hiding this comment.
Great point, will create an issue and kick-off a follow up discussion on this with @jsecretan and @hspencer77, we could definitely explore more options regarding the actions we want to take after this expired on dynamo, code would stay the same for go-sync here so merging.
yrliou
added a commit
that referenced
this pull request
Jun 10, 2020
Revert "Merge pull request #22 from brave/ttl"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21