Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous objects if updatecheck status = noupdate #70

Closed
mschfh opened this issue Mar 15, 2023 · 0 comments · Fixed by #71
Closed

Remove extraneous objects if updatecheck status = noupdate #70

mschfh opened this issue Mar 15, 2023 · 0 comments · Fixed by #71
Assignees

Comments

@mschfh
Copy link
Contributor

mschfh commented Mar 15, 2023

The current implementation returns manifest and urls objects even if there is no update available:

expectedResponse = `<response protocol="3.1" server="prod">
<app appid="ldimlcelhnjgpjjemdjokpgeeikdinbm">
<updatecheck status="noupdate">
<urls>
<url codebase="https://` + extension.GetS3ExtensionBucketHost(lightThemeExtensionID) + `/release/ldimlcelhnjgpjjemdjokpgeeikdinbm/extension_1_0_0.crx"></url>
</urls>
<manifest version="1.0.0">
<packages>
<package name="extension_1_0_0.crx" hash_sha256="1c714fadd4208c63f74b707e4c12b81b3ad0153c37de1348fa810dd47cfc5618" required="true"></package>
</packages>
</manifest>
</updatecheck>
</app>
</response>`

According to the spec, those should not be set unless there is an update available:

Additionally, the following members are set if and only if status == "ok":
manifest: A manifest object.
urls: A urls object.

@mschfh mschfh changed the title Remove extraneous objects if updatecheck status noupdate Remove extraneous objects if updatecheck status = noupdate Mar 15, 2023
@mschfh mschfh self-assigned this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant