This repository has been archived by the owner on May 2, 2023. It is now read-only.
Make enclave application build reproducibly. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This commit makes the example application build reproducibly on different platforms, i.e., a build on Linux and macOS will result in an identical image. To accomplish this, the following was necessary: * Used new flags and environment variables to build the nitriding executable. The use of -ldflags="-s -w" reduces the binary size. * Don't use "apk add". Instead, use a python base image and take advantage of the built-in urllib.request module. * Add the flag "--custom-platform linux/amd64" to kaniko, which is necessary on non-Linux, non-amd64 platforms like macOS. * Revise the Dockerfile so that inconsistent file permissions on the host don't affect the Docker image. Unrelated to the above, this commit also refactors the Makefile and adds a script that starts gvproxy.
NullHypothesis
force-pushed
the
reproducible-example
branch
from
46f37a0
to
d6c32ad
Compare
rillian
approved these changes
Apr 17, 2023
| COPY service.py / | ||
| COPY start.sh / | ||
| # Clone the repository and build the stand-alone nitriding executable. | ||
| RUN git clone https://github.com/brave/nitriding.git |
There was a problem hiding this comment.
Doesn't this make it harder to test local changes?
There was a problem hiding this comment.
It does but I'm fine with that considering that this is just an example application.
| import requests | ||
| import urllib.request |
There was a problem hiding this comment.
Using the standard library for a smaller footprint, good. The built-in client is ok for this minimal usage. from urllib.request import urlopen would be more idiomatic.
NullHypothesis
pushed a commit
that referenced
this pull request
Apr 21, 2023
Make enclave application build reproducibly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the example application build reproducibly on different platforms, i.e., a build on Linux and macOS will result in an identical image. To accomplish this, the following was necessary:
Used new flags and environment variables to build the nitriding executable. The use of -ldflags="-s -w" reduces the binary size.
Don't use "apk add". Instead, use a python base image and take advantage of the built-in urllib.request module.
Add the flag "--custom-platform linux/amd64" to kaniko, which is necessary on non-Linux, non-amd64 platforms like macOS.
Revise the Dockerfile so that inconsistent file permissions on the host don't affect the Docker image.
Unrelated to the above, this commit also refactors the Makefile and adds a script that starts gvproxy.