Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTTPS Everywhere component test #555

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove HTTPS Everywhere component test #555

wants to merge 3 commits into from

Conversation

stephendonner
Copy link
Contributor

Fixes #554

@stephendonner stephendonner self-assigned this Nov 22, 2023
@LaurenWags
Copy link
Member

The reference to this component should be removed from all templates. It is listed in https://github.com/brave/qa-resources/blob/master/WikiTemplate/Desktop/Major_CR_Bump/wikitemplate-majorChromiumBumpUpgrades.md as well, possibly others.

@stephendonner
Copy link
Contributor Author

The reference to this component should be removed from all templates. It is listed in https://github.com/brave/qa-resources/blob/master/WikiTemplate/Desktop/Major_CR_Bump/wikitemplate-majorChromiumBumpUpgrades.md as well, possibly others.

Thanks; searched GitHub and local files, and I've added the above removal, now, which was the only other one left.

LaurenWags
LaurenWags approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

MadhaviSeelam
MadhaviSeelam approved these changes Nov 27, 2023
View reviewed changes
Copy link

@MadhaviSeelam MadhaviSeelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

stephendonner
stephendonner commented Jun 14, 2024
View reviewed changes
WikiTemplate/Desktop/wikitemplate.md
@@ -193,7 +193,7 @@
- [ ] `CertificateRevocation`
- [ ] `cffkpbalmllkdoenhmdmpbkajipdjfam`: `rs-ABPFilterParserData.dat` & `regional_catalog.json` (AdBlock)
- [ ] `gccbbckogglekeggclmmekihdgdpdgoe`: (Sponsored New Tab Images)
- [ ] `oofiananboodjbbmdelgdommihjbkfag`: HTTPSE
- [ ] `jicbkmdloagakknpihibphagfckhjdih`: `speedreader-updater.dat`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where this change snuck in from, but are they ok to sneak in, so I don't have to rebase/fix merge conflicts yet again, @LaurenWags ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

@MadhaviSeelam MadhaviSeelam MadhaviSeelam approved these changes

Assignees

@stephendonner stephendonner

Labels
testsheet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the test for HTTPS Everywhere for Brave from the testsheet
3 participants
@stephendonner @LaurenWags @MadhaviSeelam