osMaxPos rounding to digit parameter #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osMaxPos() always rounds position sizes to 0. Other functions will allow a digits argument to control rounding (rulePctEquity). Added digits argument defaulting to 0. man/osMaxPos.Rd: Updated documentation for new digits parameter.
|
The comment above each line that calls |
joshuaulrich
added a commit
that referenced
this pull request
Jul 9, 2016
The .Rd files were edited directly and no roxygen comments were added to document the new parameters. Clarify what the new 'digits' parameter to osMaxPos does, and remove the trailing period from the 'account' parameter to be consistent with the other parameter documentation for the function.
|
currencies may be bought in fractions, though this is extremely rare, usually fractional currencies would only used for cross-account currency sweeps, not trading, so it is unclear what the utility of the extra parameter and rounding is, but it shouldn't be dangerous. rulePctEquity has always allowed rounding so that you could round to a desired percentage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osMaxPos() always rounds position sizes to 0. Other functions will
allow a digits argument to control rounding (rulePctEquity). Added
digits argument defaulting to 0.
man/osMaxPos.Rd:
Updated documentation for new digits parameter.