Check for already-existing image before building image #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error if the image exists instead of overwriting it. Prompt user with what steps to take if they want to replace existing image in err message.
idroz
approved these changes
Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bravetools will silently overwrite existing images. At best, this can be a waste of time and resources rebuilding an identical image. However, it is also possible that the user intended to update the image to a new version and forgot to increment the version, which would wipe the old image version without warning.
It would be safer to return an error if the image exists instead of overwriting it. The err type is checked so that we can prompt user with the steps to take if they want to replace existing image in err message (first remove image with
brave remove -i [name]).