Concurrent multipass info #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend.Infois called in the course of most bravetools commands but takes an unexpectedly long time to complete on Multipass on Windows - generally several seconds (I've seen up to 9 seconds, but more commonly 8-8.5). This makes normal usage of the tool feel slow and less snappy - for example when stopping/starting multiple units there's often a delay after each command.This change makes the calls within multipass Info concurrent, speeding up the function by a few seconds (I've saved about 2 seconds on average, from 8.6 -> 6.4 seconds). This makes a surprisingly big difference when running many small bravetools commands sequentially.