Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource panic #228

Merged
merged 2 commits into from Dec 3, 2022
Merged

Resource panic #228

merged 2 commits into from Dec 3, 2022

Conversation

Szubie
Copy link
Collaborator

@Szubie Szubie commented Dec 2, 2022 •
edited

Addresses #220

Changes:

  • No longer panic when empty RAM string is provided.
  • Skip network device config if no static IP requested

With this change it's possible to skip resource checks by providing an empty string "" to the values for RAM/CPU.

@Szubie Szubie linked an issue Dec 2, 2022 that may be closed by this pull request
Not possible to skip resource checks #220
Closed
@idroz idroz merged commit a0f1e88 into bravetools:master Dec 3, 2022
@Szubie Szubie deleted the resource-panic branch December 21, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to skip resource checks
2 participants
@Szubie @idroz