Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error when an unrecognized package manager is encountered. #80

Merged
merged 1 commit into from Jun 8, 2022

Conversation

Szubie
Copy link
Collaborator

@Szubie Szubie commented Jun 8, 2022

Currently, if a typo is made when specifying the package manager, bravetools will silently skip the package installation phase of the build without any warning. This can lead to "successfully" publishing containers that don't actually work due to the lacking dependencies.

@idroz idroz merged commit 96c755a into bravetools:master Jun 8, 2022
@Szubie Szubie deleted the invalid-package-managers branch June 10, 2022 13:58
@Szubie Szubie restored the invalid-package-managers branch June 10, 2022 13:59
@Szubie Szubie deleted the invalid-package-managers branch June 10, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants