Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bravetools uses the current username for:
However, there are various rules regarding valid names for the above. In particular, multipass VM names and LXD network bridge names are most likely to cause issues.
This pull request attempts to sanitize usernames so that they are valid for all the above uses. It is purposefully overly-cautious by stripping any non alpha-numeric charcaters to avoid dealing with those edge cases (for now). The username is actually restricted to 12 characters maximum, since "br0" is appended to the name to create the network bridge name.
Problems
This approach of attempting to clean usernames has some issues - after truncating or removing characters from usernames the username may no longer be a unique identifier. However, at least this change would at least let users who otherwise would not be able to use bravetools with their current username use the program.