Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address apk update pause #93

Merged
merged 1 commit into from Jun 20, 2022

Conversation

Szubie
Copy link
Collaborator

@Szubie Szubie commented Jun 20, 2022

Small bugfix to address specific apk update issue.

Running apk update does not close the DataDone channel unlike most other commands, leading to waiting for prompt from user before continuing. To address this use a goroutine to call op.Wait and close a channel to signal completion to select call instead.

…er commands, leading to waiting for prompt from user before continuing. To address this use a goroutine to call op.Wait and close a channel to signal completion to select call instead.
@idroz
Copy link
Contributor

idroz commented Jun 20, 2022

This is probably unrelated to this pull request, but my current tests are failing with:

# github.com/bravetools/bravetools/platform [github.com/bravetools/bravetools/platform.test]
./host_api_test.go:110:24: not enough arguments in call to host.Postdeploy
	have (*"github.com/bravetools/bravetools/shared".Bravefile)
	want (context.Context, *"github.com/bravetools/bravetools/shared".Bravefile)

@idroz
Copy link
Contributor

idroz commented Jun 20, 2022

This is probably unrelated to this pull request, but my current tests are failing with:

# github.com/bravetools/bravetools/platform [github.com/bravetools/bravetools/platform.test]
./host_api_test.go:110:24: not enough arguments in call to host.Postdeploy
	have (*"github.com/bravetools/bravetools/shared".Bravefile)
	want (context.Context, *"github.com/bravetools/bravetools/shared".Bravefile)

Addressing this in 7ccbe6a

@idroz idroz merged commit b56dfaf into bravetools:master Jun 20, 2022
@idroz
Copy link
Contributor

idroz commented Jun 20, 2022

tests now pass

@Szubie
Copy link
Collaborator Author

Szubie commented Jun 20, 2022

Thanks - good fix for the tests. The issue encountered in this PR (apk update freezing) doesn't seem to happen to me on Linux, but it did on Windows, so good to have it fixed.

@Szubie Szubie deleted the apk-update-channel-closure branch June 20, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants