Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the trait core::cmp::Ord is not implemented for the type histogram::HistogramBucket #1

Closed
posix4e opened this issue Sep 4, 2015 · 4 comments
Labels

Comments

@posix4e
Copy link

posix4e commented Sep 4, 2015

Could this be based on the id?

@brayniac
Copy link
Owner

brayniac commented Sep 4, 2015

I'm curious about use-case for this. Should be a trivial change. But is a
bucket less than another if its id is lower (and thus the value)? Or if the
count is lower?

I need to give this some more thought. Having a clear use-case to consider
will help. Is there any reason not to compare the buckets by id or count
directly depending on intent?

On Thu, Sep 3, 2015, 5:42 PM Alex Newman notifications@github.com wrote:

Could this be based on the id?


Reply to this email directly or view it on GitHub
#1.

@posix4e
Copy link
Author

posix4e commented Sep 4, 2015

Actually this would be for calculating min,max,stddev,etc

@brayniac
Copy link
Owner

brayniac commented Sep 4, 2015

There's no total ordering of buckets that makes sense as a default. I'm unwilling to implement an order when the semantics are unclear.

@posix4e
Copy link
Author

posix4e commented Sep 4, 2015

Sounds good thanks for you attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants