Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-2639 Update performance by segment #6584

Merged
merged 11 commits into from
Jan 4, 2024
Merged

BD-2639 Update performance by segment #6584

merged 11 commits into from
Jan 4, 2024

Conversation

rachel-feinberg
Copy link
Contributor

@rachel-feinberg rachel-feinberg commented Dec 4, 2023

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

Closes #BD-2639

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

@rachel-feinberg rachel-feinberg added the status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet. label Dec 18, 2023
@rachel-feinberg rachel-feinberg removed the status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet. label Jan 3, 2024
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left 2 suggestions and it looks like you have a merge conflict for an image according to the PR

rachel-feinberg and others added 2 commits January 3, 2024 16:23
…erstanding_segment_data.md

Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
…erstanding_segment_data.md

Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lydia-xie lydia-xie merged commit 1e748ff into develop Jan 4, 2024
3 checks passed
@lydia-xie lydia-xie deleted the bd-2639 branch January 4, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants