Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3909] visionOS initial documentation #7139

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

lowip
Copy link
Contributor

@lowip lowip commented Apr 2, 2024

Pull Request/Issue Resolution

Description of Change:

Adding a documentation page describing the supported, partially supported and unsupported features for visionOS

Is this change associated with a Braze feature/product release?

  • No

For reviewers

Not sure if we should add anything else, let me know if you have suggestions.


✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@josh-mccrowell-braze
Copy link
Collaborator

Assigning @internetisaiah as the reviewer when the PR is ready to be moved out of draft.

@lowip lowip requested a review from a team April 3, 2024 08:23
@lowip lowip marked this pull request as ready for review April 3, 2024 08:23
Co-authored-by: Jackson Miller <71667842+jacksonemiller@users.noreply.github.com>
Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
Copy link
Contributor

@hokstuff hokstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits - LGTM!

lowip and others added 4 commits April 4, 2024 10:06
…nos.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
…nos.md

Co-authored-by: Vanessa Landayan <vanessa.landayan@braze.com>
…nos.md

Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
@lowip
Copy link
Contributor Author

lowip commented Apr 8, 2024

Hey @internetisaiah, this is ready for your review. You can merge it as your convenience.

@internetisaiah
Copy link
Contributor

Awesome! I'll start reviewing today!

@internetisaiah
Copy link
Contributor

@cla-bot check

Copy link

cla-bot bot commented Apr 8, 2024

The cla-bot has been summoned, and re-checked this pull request!

@internetisaiah
Copy link
Contributor

@cla-bot check

Copy link

cla-bot bot commented Apr 9, 2024

The cla-bot has been summoned, and re-checked this pull request!

@internetisaiah internetisaiah merged commit 5c2b13e into develop Apr 9, 2024
2 checks passed
@internetisaiah internetisaiah deleted the SDK-3909-visionOS-documentation-page branch April 9, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants