-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4810] Flutter docs - Push Events in Dart layer #7159
Conversation
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
Thanks for tagging me! Because Isaiah is focused on revamping things for the wrapper docs right now, I'll let him take the lead on this one. @internetisaiah , if you need support, happy to give this a style review. Just let me know. |
@josh-mccrowell-braze , thanks for the heads up. I took a quick skim and I'll probably merge most of it as-is so I'm not rewriting twice. I'm fine with something like this for a temporary fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hokstuff hey there, everything looks good to me and I gave it the ✅ . Do you want me to merge now or should I hold off until the new flutter updates go out? |
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Outdated
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Outdated
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few nits regarding the links for the Android integration. It's nice to have this guide to pair with the new release 💯
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
_docs/_developer_guide/platform_integration_guides/flutter/push_notifications.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @internetisaiah, we just released the complementary Flutter version 9.0.0, so we should be good to merge and release this docs update. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request/Issue Resolution
Description of Change:
https://jira.braze.com/browse/SDK-4810
Is this change associated with a Braze feature/product release?
✔️ Pull Request Checklist
assets
>js
>broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
Technology partners
Channels
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
SMS
User Targeting
Reporting