Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4810] Flutter docs - Push Events in Dart layer #7159

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

hokstuff
Copy link
Contributor

@hokstuff hokstuff commented Apr 3, 2024

Pull Request/Issue Resolution

Description of Change:

I'm changing..... (could be a link, a new image, a new section, etc.)... because...

https://jira.braze.com/browse/SDK-4810

Is this change associated with a Braze feature/product release?


✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
@hokstuff hokstuff requested a review from a team April 3, 2024 21:22
@hokstuff hokstuff requested review from a team, josh-mccrowell-braze and internetisaiah and removed request for a team April 8, 2024 22:18
@josh-mccrowell-braze
Copy link
Collaborator

Thanks for tagging me! Because Isaiah is focused on revamping things for the wrapper docs right now, I'll let him take the lead on this one. @internetisaiah , if you need support, happy to give this a style review. Just let me know.

@internetisaiah
Copy link
Contributor

@josh-mccrowell-braze , thanks for the heads up. I took a quick skim and I'll probably merge most of it as-is so I'm not rewriting twice. I'm fine with something like this for a temporary fix.

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@internetisaiah
Copy link
Contributor

@hokstuff hey there, everything looks good to me and I gave it the ✅ . Do you want me to merge now or should I hold off until the new flutter updates go out?

@internetisaiah internetisaiah added the status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet. label Apr 9, 2024
Copy link
Contributor

@vanessaland vanessaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits regarding the links for the Android integration. It's nice to have this guide to pair with the new release 💯

Copy link
Contributor

@jerielng jerielng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hokstuff
Copy link
Contributor Author

hokstuff commented Apr 9, 2024

Hi @internetisaiah, we just released the complementary Flutter version 9.0.0, so we should be good to merge and release this docs update. Thanks!

@internetisaiah internetisaiah self-requested a review April 10, 2024 22:55
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@internetisaiah internetisaiah merged commit f52ea66 into develop Apr 11, 2024
2 checks passed
@internetisaiah internetisaiah deleted the SDK-4810-flutterPushOpened branch April 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants