-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flag changelogs + naming practices #7226
Conversation
hey @internetisaiah this shouldn't be in the Canvas component section - this is for feature flag rollouts. otherwise looks good. can we add this to https://www.braze.com/docs/developer_guide/platform_wide/feature_flags/create/ |
@bkasman95 , I migrated the content over to the correct doc 👍🏽 . I also ended up cleaning up the dev guide doc since the headings felt clunky with the new content. Once you give this a quick review, I'll merge the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look good to me!
added @davidbielik to give a quick review, but looks good to me! |
| Permission | What you can do | | ||
|-------------------------------------------------------------------------------|-------------------------------------------| | ||
| **Manage Feature Flags** | View, create, and edit feature flags. | | ||
| **Access Campaigns, Canvases, Cards, Feature Flags, Segments, Media Library** | View the list of available feature flags. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this one required for experiments only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I didn't change anything here, I just changed the format from a list to a table. But I'm happy to tweak in this PR if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkasman95 can you find out when each of the two permissions is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidbielik and @bkasman95 , I'm going to merge this for now since this is what's on the existing doc. Once you find out this info @bkasman95 , please create another ticket for our team to update this! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few items of feedback, but lgtm
Pull Request/Issue Resolution
Description of Change:
Adding documentation for feature flag changelogs. This also includes updates to the recommended naming practices for feature flags.
Additional notes
Are the label names too late to change in the UI? If not, I'd suggest changing the word "Action" to "Step" (or similar). From what I can tell the word "Action" doesn't show up when creating or editing a feature flag, so the word feels a bit hard to describe. Furthermore, it requires the end-user to learn a new piece of vocab instead of recycling Braze vocab they may already be familiar with. Let me know your thoughts!
Is this change associated with a Braze feature/product release?
✔️ Pull Request Checklist
assets
>js
>broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
Technology partners
Channels
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
SMS
User Targeting
Reporting