Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
camilamaia committed Jun 7, 2024
1 parent 72d6eea commit 6c081ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions brutils/voter_id.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def _calculate_vd2(federative_union, vd1): # type: (str, int) -> str
return vd2


def generate(state="ZZ") -> str:
def generate(federative_union ="ZZ") -> str:
"""
Generates a random valid Brazilian voter registration.
Expand Down Expand Up @@ -259,7 +259,7 @@ def generate(state="ZZ") -> str:
if federative_union in (UFs):
sequential_number = str(randint(0, 99999999)).zfill(8)
uf_number = UFs[federative_union]
if _is_uf_number_valid(uf_number):
if _is_federative_union_valid(uf_number):
vd1 = _calculate_vd1(sequential_number, uf_number)
vd2 = _calculate_vd2(uf_number, vd1)
return f"{sequential_number}{uf_number}{vd1}{vd2}"
6 changes: 3 additions & 3 deletions tests/test_voter_id.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,19 +92,19 @@ def test_calculate_vd2(self):

def test_generate_voter_id(self):
# test if is_valid a voter id from MG
voter_id = generate(state="MG")
voter_id = generate(federative_union ="MG")
self.assertIs(is_valid(voter_id), True)

# test if is_valid a voter id from AC
voter_id = generate(state="AC")
voter_id = generate(federative_union ="AC")
self.assertIs(is_valid(voter_id), True)

# test if is_valid a voter id from foreigner
voter_id = generate()
self.assertIs(is_valid(voter_id), True)

# test if UF is not valid
voter_id = generate(state="XX")
voter_id = generate(federative_union ="XX")
self.assertIs(is_valid(voter_id), False)


Expand Down

0 comments on commit 6c081ad

Please sign in to comment.