Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refatoracao cnpj #118

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Refatoracao cnpj #118

merged 1 commit into from
Jul 1, 2023

Conversation

camilamaia
Copy link
Member

@camilamaia camilamaia commented Jul 1, 2023 •
edited
Loading

  • hashdigit convertido para privado
  • checksum convertido para privado
  • test_generate para cnpj testando criação de 10k cnpj ao invés de 1k

Closes #117

@codecov
Copy link

codecov bot commented Jul 1, 2023 •
edited
Loading

Codecov Report

Merging #118 (88e4a75) into main (ff63c18) will increase coverage by 1.49%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #118      +/-   ##
===========================================
+ Coverage   98.50%   100.00%   +1.49%     
===========================================
  Files           3         3              
  Lines          67        65       -2     
===========================================
- Hits           66        65       -1     
+ Misses          1         0       -1
Impacted Files Coverage Δ
brutils/cnpj.py 100.00% <100.00%> (+2.77%) ⬆️

antoniamaia
antoniamaia approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@antoniamaia antoniamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @camilamaia! You are awesome!! ❤️

@camilamaia camilamaia merged commit 7a3249d into main Jul 1, 2023
10 checks passed
@camilamaia camilamaia deleted the 117 branch July 1, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniamaia antoniamaia antoniamaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tapa no arquivo de CNPJ
2 participants
@camilamaia @antoniamaia