Capítulo 03, review 02 até linha 10 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isso, é a forma que eu uso para fazer revisão. Conforme for fazendo vou ajudando aqui fazendo comentários e sugestões a respeito ;) |
|
Ótimo @joaostein dessa forma fica excelente mesmo! |
ericdouglas
added a commit
that referenced
this pull request
Jan 31, 2015
Capítulo 03, review 02 até linha 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segunda iteração. Pode ser uma boa ideia dar uma review no meu review antes de dar um merge e adicionar comentários linha por linha caso veja algo que passou despercebido. Se achar interessante levantar uma discussão em algum termo/frase também é bem vindo :)
Estou usando uma política de commit fast and often, portanto a medida que for traduzindo pequenos pedaços, já vou fazendo os pr's.
referência: #9 #288