Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby resources links #50

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Update Ruby resources links #50

merged 1 commit into from
Aug 5, 2019

Conversation

javimbk
Copy link
Contributor

@javimbk javimbk commented Jul 24, 2019

Hello, first of all thank you for your work with the floating point guide, I think it's a great asset.

I'm a Ruby fan, and I was looking into the Ruby section and realised two things:

  1. Links to Ruby-doc were not working due to how they are working out http -> https redirection on their end. I know it's not a problem caused by this project, but it is easily solvable redirecting to the https link (which should be better).
  2. Links were pointing to Ruby 2.1.2 version. Ruby 2.1 support ended on March 2017, so it doesn't hurt to have something a little bit more updated, since we are already making some changes on this.

It was my pleasure to do this, and I hope to see the floating point guide being a great asset and reference for all developers out there.

@brazzy brazzy merged commit 5aee989 into brazzy:master Aug 5, 2019
@brazzy
Copy link
Owner

brazzy commented Aug 5, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants