Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caption in file blocks #37

Merged
merged 2 commits into from
Mar 9, 2024
Merged

feat: add caption in file blocks #37

merged 2 commits into from
Mar 9, 2024

Conversation

brd6
Copy link
Owner

@brd6 brd6 commented Mar 9, 2024

Description

Add caption property in the file blocks.

Motivation and context

Captions property are not available in the Video and Image blocks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 51.31%. Comparing base (add38da) to head (ca47bf6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #37      +/-   ##
============================================
- Coverage     51.34%   51.31%   -0.03%     
- Complexity     1005     1008       +3     
============================================
  Files           216      216              
  Lines          2723     2732       +9     
============================================
+ Hits           1398     1402       +4     
- Misses         1325     1330       +5     
Files Coverage Δ
src/RequestParameters.php 100.00% <ø> (ø)
src/Resource/AbstractResource.php 85.71% <ø> (ø)
src/Resource/Block/AbstractBlock.php 67.90% <ø> (ø)
src/Resource/RichText/AbstractRichText.php 63.63% <ø> (ø)
src/Resource/File/AbstractFile.php 69.23% <44.44%> (-7.44%) ⬇️

@brd6 brd6 merged commit 740f3b1 into main Mar 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants