-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Editor JS editor sometimes does not save changes #1898
Comments
That's really unusual 🤔 The only thing I can think of (which may not be right) is if there's something invalid entered and the state isn't properly cleared that allows it to submit again. But I'm not sure if there's anything to that idea. |
Has it happened in multiple fields, or is it always the same field (like LLM input)? |
it's only the JS editor (codemirror) field that seems to do that. |
Ah, I misunderstood, I thought it was that we weren't taking updates generally. Okay, I'll have a prod and a ponder. |
Okay, so it looks like CodeMirror swallows input events in some cases, so I've added a watcher to the editor for when stuff is removed. Can you see if this is better behaved now? |
🤞🏻 |
Also - #1929 I will add, it's not just |
This is working now, I believe. Let me know if not, but for now I'll declare victory. |
I can't quite produce a repro yet, but it seems like it occasionally gets into a funky state: after accepting edits correctly for a little while, it starts to just ignore them. The current workaround is to go to the next field ("name") and edit it. Then the changes in the JS editor start saving again.
The text was updated successfully, but these errors were encountered: