Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated files not modifying the online version #8

Closed
j-h-a opened this issue Aug 15, 2014 · 4 comments
Closed

Updated files not modifying the online version #8

j-h-a opened this issue Aug 15, 2014 · 4 comments

Comments

@j-h-a
Copy link

j-h-a commented Aug 15, 2014

I am getting "Success" message - but the file online is unchanged.

@davidmurdoch
Copy link
Owner

What OS and node version are you on?

@j-h-a
Copy link
Author

j-h-a commented Aug 15, 2014

uname -a is:
Darwin Kernel Version 13.3.0:
Tue Jun 3 21:27:35 PDT 2014;
root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64

node --version is:
v0.10.30

@j-h-a
Copy link
Author

j-h-a commented Aug 16, 2014

I delved into the code and printed some things out and managed to fix this - the problem was that I misunderstood the instructions and my directory property was set to "../shopify/theme/xxxxxx" where xxxxxx is the theme id. This resulted in a request like: PUT /admin/themes/config/assets.json (editing config/settings_data.json so it was picking up 'config' as the theme id). The solution was to remove the theme id from the directory property.

However, the fact that it is reporting a 'Success' message when the response was actually a 404 is of course still an issue. The HTTP status code should be checked before reporting any kind of result to the user.

@davidmurdoch
Copy link
Owner

Fixed in 0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants