Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created Part.file_content_field #15

Merged
merged 2 commits into from
Apr 25, 2023
Merged

created Part.file_content_field #15

merged 2 commits into from
Apr 25, 2023

Conversation

restlessronin
Copy link
Contributor

@restlessronin restlessronin commented Apr 24, 2023

I needed to be able to add file content that was already in memory to a multipart form request.

This should address / close issue #14

@restlessronin restlessronin changed the title created Part.add_file_content created Part.file_content Apr 24, 2023
@restlessronin restlessronin changed the title created Part.file_content created Part.file_content_field Apr 24, 2023
@restlessronin
Copy link
Contributor Author

Hi @tomtaylor, any chance of getting this PR in soon? I'm unable to publish my library to hex.pm until multipart has this functionality.

thanks so much for your library. it enabled me to switch openai_ex from Tesla to Finch quite painlessly.

@tomtaylor
Copy link
Contributor

@restlessronin thanks, this looks good, but could we get a unit test for it?

@restlessronin
Copy link
Contributor Author

@restlessronin thanks, this looks good, but could we get a unit test for it?

@tomtaylor Done.

@tomtaylor tomtaylor merged commit 07b68c8 into breakroom:main Apr 25, 2023
0 of 10 checks passed
@tomtaylor
Copy link
Contributor

Thanks!

@tomtaylor
Copy link
Contributor

Released in 0.4.0.

@restlessronin
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants