This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
Fix query string hash with false parameters #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the JWTClient to send a query with a parameter that has a value of '' or '0', the QSH and resulting JWT signature doesn't match and Atlassian rejects it with a 401.
An example might be using
/rest/api/3/worklog/updated?since=0to retrieve worklogs updated since the beginning of time. The current code to handle parameter-only query strings will accidentally activate on strings that are considered false in PHP, so it will be treated like it's justsince. As a result, it hashesGET&/rest/api/3/worklog/updated&sinceinstead of the expectedGET&/rest/api/3/worklog/updated&since=0. The same problem also occurs if you send an empty parameter, likeproperties=.This PR fixes the code to properly differentiate between
?param,?param=and?param=0and adds some tests for these cases. According to the PHP docs on boolean casting, there shouldn't be any other string values that are considered false, so I think these tests are enough.