Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when using with styled-components css prop #127

Closed
likern opened this issue Nov 11, 2021 · 2 comments · Fixed by #128
Closed

Exception when using with styled-components css prop #127

likern opened this issue Nov 11, 2021 · 2 comments · Fixed by #128
Assignees
Labels
issue: bug Something isn't working os: android Operating System: Android package: icons

Comments

@likern
Copy link
Contributor

likern commented Nov 11, 2021

When using styled-components css property, testID property is passed down to <Icon /> component, which leads to exception.

import 'styled-components/macro';
...
<Icon
 css={`
   margin-left: 14px;
 `}
  color={`${
    iconColor !== undefined ? iconColor : 'rgba(38, 47, 86, 1)'
  }`}
  icon={['far', iconName]}
  size={24}
/>
@likern likern added issue: bug Something isn't working os: android Operating System: Android package: icons labels Nov 11, 2021
@likern likern self-assigned this Nov 11, 2021
@github-actions
Copy link
Contributor

Branch issue-127 created. Open it in the web editor.

github-actions bot pushed a commit that referenced this issue Nov 11, 2021
@likern likern changed the title Exception with using with styled-components css prop Exception when using with styled-components css prop Nov 11, 2021
@likern likern mentioned this issue Nov 11, 2021
3 tasks
@likern
Copy link
Contributor Author

likern commented Nov 11, 2021

Because of #129 issue, don't pass testID down, just skip when it's passed and don't throw exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Something isn't working os: android Operating System: Android package: icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant