Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow items to be strings convertible to numbers #142

Closed
likern opened this issue Nov 28, 2021 · 2 comments · Fixed by #143
Closed

Allow items to be strings convertible to numbers #142

likern opened this issue Nov 28, 2021 · 2 comments · Fixed by #143
Assignees
Labels

Comments

@likern
Copy link
Contributor

likern commented Nov 28, 2021

In <NumberPicker ... /> component items property is number[].
If we use specially formatted numbers by Intl.NumberFormat items might become strings.

const HourAndMinutesNumberFormat = new Intl.NumberFormat('en-US', {
  style: 'decimal',
  // @ts-ignore
  signDisplay: 'never',
  useGrouping: false,
  minimumIntegerDigits: 2
});

We can allow items to be strings, but which should be convertible to numbers.

@likern likern added issue: feature Pull request with new feature package: pickers labels Nov 28, 2021
@likern likern changed the title Allow items to be strings convertible to number Allow items to be strings convertible to numbers Nov 28, 2021
@likern
Copy link
Contributor Author

likern commented Nov 28, 2021

Screenshot_2021-11-28-17-32-59-130_com breeffy feeve

@likern likern self-assigned this Nov 28, 2021
@github-actions
Copy link
Contributor

Branch issue-142 created. Open it in the web editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant