Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored validateJob method complexity #56

Merged
merged 26 commits into from Dec 9, 2020
Merged

Refactored validateJob method complexity #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9c47a1c
chore: refactored isSchedule method into utils module
naz Nov 25, 2020
2b1315a
chore: refactored getName method into utils module
naz Nov 25, 2020
7764022
chore: refactored a method to build a job out of string or function
naz Nov 25, 2020
d470d2e
chore: refactored getHumanToMs and parseValue function to utils
naz Nov 25, 2020
050ec04
chore: extracted buildJob method out of validateJob
naz Nov 25, 2020
ad259e4
chore: refactored buildJob into separate module
naz Nov 25, 2020
bbe1332
fix: sneaky bastard broke browserify build&tests
naz Nov 25, 2020
ce39517
fix: fixed job name retreival for error message
naz Nov 26, 2020
a1cd25f
fix: fixed index for job missing name
naz Nov 26, 2020
475a0e7
chore: refactored unique job name validation
naz Nov 26, 2020
7bbb690
chore: refactored jobValidate method into separate module
naz Nov 26, 2020
06ef310
chore: refactored function job validation
naz Nov 26, 2020
869e5c7
chore: refactored string job validation
naz Nov 26, 2020
a62d7e8
chore: refactored cronValidate options construction
naz Nov 26, 2020
6729936
chore: refactored cron validation
naz Nov 26, 2020
e1fdbb5
chore: refactored job path validation
naz Nov 26, 2020
162038e
chore: refactored job name validation
naz Nov 26, 2020
8e9c415
chore: renamed variable to more descriptive
naz Nov 26, 2020
9c0e012
chore: refactored reserved job name validation
naz Nov 26, 2020
836e2fc
chore: removed redundant error throw
naz Nov 26, 2020
9fc2afe
refactor: removed cronValidate property from job object
naz Nov 26, 2020
62ed7b8
refactor: refactored timeout/interval validations
naz Nov 26, 2020
be12b63
test: added coverage for getJobNames
naz Nov 26, 2020
9e7f890
test: added test coverage for job validator
naz Nov 26, 2020
4cec467
test: removed field defaults to increace test coverage
naz Nov 30, 2020
baedefc
docs: added jsdoc descriptions to job utils module
naz Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view