refactor: refactor tests #75
Conversation
shadowgate15
force-pushed
the
refactor/tests
branch
4 times, most recently
from
fe9d7b8
to
356b9fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 376 382 +6
=========================================
+ Hits 376 382 +6
Continue to review full report at Codecov.
|
shadowgate15
force-pushed
the
refactor/tests
branch
from
356b9fe
to
26d7691
Compare
shadowgate15
force-pushed
the
refactor/tests
branch
7 times, most recently
from
19caba9
to
b3ab6d7
Compare
shadowgate15
force-pushed
the
refactor/tests
branch
from
b3ab6d7
to
d405891
Compare
shadowgate15
force-pushed
the
refactor/tests
branch
2 times, most recently
from
59638b8
to
6a32fca
Compare
shadowgate15
force-pushed
the
refactor/tests
branch
from
6a32fca
to
255f60a
Compare
|
v5.0.0 released https://github.com/breejs/bree/releases/tag/v5.0.0 🎉 you all rock. thank you @shadowgate15 et all |
|
hmm, @shadowgate15 builds are failing again https://travis-ci.com/github/breejs/bree/jobs/481063328 |
|
Adding test results here to simplify analysis: 1 Failing test, same for Node 10 and Node 12. start › sets interval if date is in the future and interval is schedule ==> Promise returned by test never resolved And test coverage of index.js is below 100%. |
|
@niftylettuce @shadowgate15 when I run test suite locally with Node12 all tests are green. Quite strange. Any ideas for possible reason? |
|
Travis CI sucks... that is literally the only reason I have... I have probably spent 24+ hours trying to make them pass on CI... they won't show up on local... |
|
tests seem to pass with this a7e6673 😄 |
|
v5.0.1 released, back to 100%! |
I refactor the tests and broke them up into separate files.
It is still having some issues with flakiness on CI. I can't figure out why though... It seems to be a timing issue, however it is running into issues on tests that are being run serially...