Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in version 1.1.1 #4

Closed
dougg0k opened this issue Feb 17, 2022 · 5 comments
Closed

Error in version 1.1.1 #4

dougg0k opened this issue Feb 17, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@dougg0k
Copy link

dougg0k commented Feb 17, 2022

Are tsconfig-paths required now?

[2022-02-17 03:08:38 PM UTC] ERROR (243 on 8e1b2f01714f): Cannot find module 'tsconfig-paths'
Require stack:
- /app/node_modules/@breejs/ts-worker/src/worker.js
    err: {
      "type": "Error",
      "message": "Cannot find module 'tsconfig-paths'\nRequire stack:\n- /app/node_modules/@breejs/ts-worker/src/worker.js",
      "stack":
          Error: Cannot find module 'tsconfig-paths'
          Require stack:
          - /app/node_modules/@breejs/ts-worker/src/worker.js
              at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
              at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/app/node_modules/@cspotcode/source-map-support/source-map-support.js:679:30)
              at Function.Module._load (node:internal/modules/cjs/loader:778:27)
              at Module.require (node:internal/modules/cjs/loader:999:19)
              at require (node:internal/modules/cjs/helpers:102:18)
              at Object.<anonymous> (/app/node_modules/@breejs/ts-worker/src/worker.js:4:1)
              at Module._compile (node:internal/modules/cjs/loader:1097:14)
              at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
              at Module.load (node:internal/modules/cjs/loader:975:32)
              at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      "code": "MODULE_NOT_FOUND",
      "requireStack": [
        "/app/node_modules/@breejs/ts-worker/src/worker.js"
      ]
    }

Solution was to use 1.0.1.

@dougg0k dougg0k added the bug Something isn't working label Feb 17, 2022
@shadowgate15
Copy link
Member

Currently it does. It is listed as a peer dependency. However, I think we should have it just check for tsconfig-paths and only if it exists use it to determine paths.

@dougg0k
Copy link
Author

dougg0k commented Jun 13, 2022

After having upgraded breejs to 9.0.1, I get this with version 1.0.1.

[2022-06-13 02:20:21 PM UTC] ERROR (48 on c503f442f253): Cannot read properties of undefined (reading 'endsWith')
    err: {
      "type": "TypeError",
      "message": "Cannot read properties of undefined (reading 'endsWith')",
      "stack":
          TypeError: Cannot read properties of undefined (reading 'endsWith')
              at Bree.createWorker (/app/node_modules/@breejs/ts-worker/src/index.js:20:18)
              at Bree.run (/app/node_modules/bree/src/index.js:371:35)
    }

@shadowgate15
Copy link
Member

Could you please run with DEBUG=bree:* and upload the log? For some reason, the worker creator is receiving an undefined filename.

@dougg0k
Copy link
Author

dougg0k commented Jun 13, 2022

I wont use v9, I downgraded to 8.0.5 and it's working fine.

@titanism
Copy link
Contributor

@dougg0k we just released v2.0.0, which fixes this issue! 🎉

https://github.com/breejs/ts-worker/releases/tag/v2.0.0

You should be successfully able to use bree@9 and @breejs/ts-worker@2 now, thanks for filing the GH issue.

titanism added a commit that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants