Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cargo fmt #307

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Run cargo fmt #307

merged 2 commits into from
Jul 14, 2023

Conversation

ademar111190
Copy link
Contributor

Just run cargo fmt on some file to reduce the changes here #294

@ademar111190 ademar111190 self-assigned this Jul 10, 2023
@ademar111190 ademar111190 mentioned this pull request Jul 10, 2023
Merged
ademar111190
ademar111190 commented Jul 11, 2023
View reviewed changes
libs/sdk-bindings/src/breez_sdk.udl Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did format this file as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@roeierez
Copy link
Member

@ademar111190 Looks good but I wonder why our CI doesn't fail: https://github.com/breez/breez-sdk/blob/main/.github/workflows/main.yml#L22

@ademar111190
Copy link
Contributor Author

@ademar111190 Looks good but I wonder why our CI doesn't fail: https://github.com/breez/breez-sdk/blob/main/.github/workflows/main.yml#L22

I don't know either, maybe a different version?

My version:

 $ which cargo
 /Users/ademar/.cargo/bin/cargo
 $ cargo --version 
 cargo 1.69.0 (6e9a83356 2023-04-12)

@ademar111190 ademar111190 merged commit cf4423b into main Jul 14, 2023
2 checks passed
@ademar111190 ademar111190 deleted the run-cargo-fmt branch July 14, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

Assignees

@ademar111190 ademar111190

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ademar111190 @roeierez