Baseline RN code generation #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roeierez I have successfully tested the generated code in the Satimoto app. It took a bit of code rework to handle the updated type structure and the inclusion of type variants. Specific parts affected are lightning payment (including payment events) handling, LNURL result types and the interfaces to setLogStream (renamed from startLogStream) and connect (adds event handler as third param) I will rebase, regenerate the baseline and merge |
dangeross
force-pushed
the
savage-rn-generator
branch
from
9a83fb6
to
b1a916d
Compare
dangeross
force-pushed
the
savage-baseline-rn-generation
branch
from
63a590d
to
5d72748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First code generation from #429