Check if send_payment invoice is already paid #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Sep 13, 2023
libs/sdk-core/src/breez_services.rs
Outdated
| .persister | ||
| .get_completed_payment_by_hash(&parsed_invoice.payment_hash)? | ||
| { | ||
| Some(_) => Err(anyhow!("Invoice already paid")), |
There was a problem hiding this comment.
Perhaps we can introduce a new SdkError here?
There was a problem hiding this comment.
I also noticed one test is failing.
There was a problem hiding this comment.
Done. Added SdkError and updated test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup the invoice payment by hash and if the payment is already completed, throw an error.
Fixes #414