Fix rev swap edge case caused by claim tx delays #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Sep 29, 2023
| // on confirmed utxos to determine the claim tx amount will result in a panic (0 - fees < 0) | ||
| // Therefore we read the claim tx amount from the originally agreed upon onchain amount, | ||
| // confirmed by the service provider on rev swap creation. | ||
| let claim_amount_sat = rs.onchain_amount_sat; |
There was a problem hiding this comment.
Isn't it better to validate that the total utxo value is at least the claim_amount_sat before constructing the transaction?
There was a problem hiding this comment.
Also why the status wasn't updated to Canceled in the call to refresh_monitored_reverse_swaps?
There was a problem hiding this comment.
Anyway I agree that to make sure we claim exactly the amount we know we need to take is better than calculating the utxo and if the tx is not valid so we will keep trying untill timeout. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rev swap is created and proceeds successfully until the lockup tx, but the claim tx is not broadcasted until after the rev swap timeout is reached (for example, because the SDK node was offline), then the service provider re-claims the locked amount and cancels the HODL invoice.
This scenario resulted in a panic when the device came back online and tried to construct and broadcast the claim tx, because of how the claim tx amount was calculated.
This PR fixes that.